bug#73078: closed ([PATCH] qutebrowser: Update to 3.2.1.)

[GNU bug Tracking System]

Your message dated Sun, 08 Sep 2024 00:09:41 +0800
with message-id <878qw31m4a.fsf@iscas.ac.cn>
and subject line Re: [bug#73078] [PATCH] qutebrowser: Update to 3.2.1.
has caused the debbugs.gnu.org bug report #73078,
regarding [PATCH] qutebrowser: Update to 3.2.1.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
73078: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73078
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] qutebrowser: Update to 3.2.1.
>
>
>
>
> Date: 
>
> Fri,  6 Sep 2024 19:23:04 +0200
>
>
>
>
> * gnu/packages/web-browser.scm (qutebrowser): Update to 3.2.1.
> [source]: Use name instead of "qutebrowser" literal.
> ---
>  gnu/packages/web-browsers.scm | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index a8c51b503b..70a58132bb 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -464,15 +464,16 @@ (define-public kristall
>  (define-public qutebrowser
>    (package
>      (name "qutebrowser")
> -    (version "3.1.0")
> +    (version "3.2.1")
>      (source
>       (origin
>         (method url-fetch)
> -       (uri (string-append "https://github.com/qutebrowser/";
> -                           "qutebrowser/releases/download/v" version "/"
> -                           "qutebrowser-" version ".tar.gz"))
> +       (uri (string-append "https://github.com/"; name "/" name
> +                           "/releases/download/v" version "/" name "-"
> +                           version ".tar.gz"))
>         (sha256
> -        (base32 "0prf9c7nx4aizfczjb0fpsn3alz210i6wc7s2jwb1mh8r8fcq3ah"))))
> +         (base32
> +           "0zc9736zpmzn7250wbgk6n1q7nc05i0vic15na3qvcsxdhmaz9q2"))))
>      (build-system python-build-system)
>      (native-inputs
>       (list python-attrs))               ; for tests
> -- 
> 2.45.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#73078] [PATCH] qutebrowser: Update to 3.2.1. Date: Sun, 08 Sep 2024 00:09:41 +0800

Herman Rimm via Guix-patches via <guix-patches@gnu.org> writes:

should "gnu: qutebrowser: Update to 3.2.1."

> * gnu/packages/web-browser.scm (qutebrowser): Update to 3.2.1.
> [source]: Use name instead of "qutebrowser" literal.
> ---
>  gnu/packages/web-browsers.scm | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index a8c51b503b..70a58132bb 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -464,15 +464,16 @@ (define-public kristall
>  (define-public qutebrowser
>    (package
>      (name "qutebrowser")
> -    (version "3.1.0")
> +    (version "3.2.1")
>      (source
>       (origin
>         (method url-fetch)
> -       (uri (string-append "https://github.com/qutebrowser/";
> -                           "qutebrowser/releases/download/v" version "/"
> -                           "qutebrowser-" version ".tar.gz"))
> +       (uri (string-append "https://github.com/"; name "/" name
> +                           "/releases/download/v" version "/" name "-"
> +                           version ".tar.gz"))

Normally we shouldn't do this, if one day we rename this package
qutebrowser-minimal the link will be wrong.
And I switched to git-fetch, because this is a better option, you can
specify the branch/commit, including downloading the source code is a
directory, you can directly cd into the file.

>         (sha256
> -        (base32 "0prf9c7nx4aizfczjb0fpsn3alz210i6wc7s2jwb1mh8r8fcq3ah"))))
> +         (base32
> +           "0zc9736zpmzn7250wbgk6n1q7nc05i0vic15na3qvcsxdhmaz9q2"))))
>      (build-system python-build-system)
>      (native-inputs
>       (list python-attrs))               ; for tests

add asciidoc for fix build

signature.asc
Description: PGP signature

--- End Message ---