bug#72858: closed ([PATCH] gnu: godot: Update to 4.3)

[GNU bug Tracking System]

Your message dated Sat, 07 Sep 2024 21:05:08 +0000
with message-id <874j6r9nup.fsf@protonmail.com>
and subject line Re: [bug#72858] [PATCH] gnu: godot: Update to 4.3
has caused the debbugs.gnu.org bug report #72858,
regarding [PATCH] gnu: godot: Update to 4.3
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
72858: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72858
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: godot: Update to 4.3
>
>
>
>
> Date: 
>
> Wed, 28 Aug 2024 13:09:03 -0500
>
>
>
>
> * gnu/packages/game-development.scm (godot): Update to 4.3.
>
> Change-Id: I9a0e11cd9299311b92b31e2be1f0099d960ddcfa
> ---
>  gnu/packages/game-development.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/game-development.scm 
> b/gnu/packages/game-development.scm
> index aff95d48a1..fe2a372493 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -2101,16 +2101,16 @@ (define-public godot-lts
>  (define-public godot
>    (package
>      (name "godot")
> -    (version "4.2.2")
> +    (version "4.3")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
>                      (url "https://github.com/godotengine/godot";)
> -                    (commit (string-append version "-stable"))))
> -              (file-name (git-file-name name version))
> +                    (commit (string-append version))))
> +              (file-name (git-file-name name version "-stable"))
>                (sha256
>                 (base32
> -                "0wm0pla6f6gvk21gbm5kiihinn05dvvprk0242m6s8c78wy60wka"))
> +                "1hg6hkysvf6znpy8rcbgkzvan3qqg3iiva7g5g6y7mjd30a6dsy3"))
>                (modules '((guix build utils)
>                           (ice-9 ftw)
>                           (srfi srfi-1)))
> -- 
> 2.45.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#72858] [PATCH] gnu: godot: Update to 4.3
>
>
>
>
> Date: 
>
> Sat, 07 Sep 2024 21:05:08 +0000
>
>
>
>
> Hello msglm and Ludo’,
>
> On Wed, Sep 04, 2024 at 07:12 PM, Ludovic Courtès wrote:
>
> > Hi,
> >
> > msglm <msglm@techchud.xyz> skribis:
> >
> >> +              (file-name (git-file-name name version "-stable"))
> >
> > The problem mentioned in my previous message is still here.
> >
> > Could you send a patch without this typo?
> >
> > Ludo’.
>
> Thanks for trying to update Godot, msglm. Unfortunately, your patch does
> not work (as noted above) and there was more to be done to update Godot,
> which I've done after testing locally (building and running). In
> particular, the snippet and a phase needed to be adjusted. Please see
> commit 123b7226a0442ee4103c04064d453421424d5fac for details if you are
> interested. I also needed to update embree (also tested locally and
> build blender with it) which was done with
> 31a55a652f8e4856fd66b47377e214b7d20b4f61.
>
> Thank you for your efforts! If you are interested, Godot has many
> bundled libraries which should be unbundled, some of which we have
> packaged (but may need updates or patching in Godot to use them) and
> others which are not packaged. It would be great to make some progress
> on that front if you'd like to work on Godot-related packaging.
>
> John
>
>
>
>
> --- End Message ---