bug#72701: closed (eglot crash when project-files-relative-names t)

[GNU bug Tracking System]

Your message dated Sun, 8 Sep 2024 23:51:43 +0300
with message-id <bf85f421-1e19-4562-8295-67308e852089@gutov.dev>
and subject line Re: bug#72701: eglot crash when project-files-relative-names t
has caused the debbugs.gnu.org bug report #72701,
regarding eglot crash when project-files-relative-names t
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
72701: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72701
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: eglot crash when project-files-relative-names t Date: Sun, 18 Aug 2024 11:43:01 -0400

project-files-relative-names was introduced a few months ago, so it's no surprise that there are some side effects when set.

This affects the handler for workspace/didChangeWatchedFiles. The result is that dirs-to-watch...

         (dirs-to-watch
          (delete-dups (mapcar #'file-name-directory
                               (project-files
                                (eglot--project server))))))

...is nil when project-files-relative-names is t, due to file-name-directory failing to parse the directories it was expecting. This results in file-readable-p failing with a nil dir:

         (watch-dir (dir)
           (when-let ((probe
                       (and (file-readable-p dir)

One solution which I've tested is simply the defensive:

         (project-files-relative-names nil) ; add this

         (dirs-to-watch
          (delete-dups (mapcar #'file-name-directory
                               (project-files
                                (eglot--project server))))))

-Stephane

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#72701: eglot crash when project-files-relative-names t
>
>
>
>
> Date: 
>
> Sun, 8 Sep 2024 23:51:43 +0300
>
>
>
>
> User-agent: 
>
> Mozilla Thunderbird
>
>
>
>
> On 08/09/2024 13:56, João Távora wrote:
> > On Sun, Sep 8, 2024 at 3:24 AM Dmitry Gutov <dmitry@gutov.dev> wrote:
> > > On 07/09/2024 10:20, Eli Zaretskii wrote:
> > > > Ping!  Is this issue resolved and can be closed, or do we need to do
> > > > anything else here?
> > >
> > > I suggest installing the following. Not a hard necessity, but seems like
> > > an improvement:
> >
> > Let's not, for all the reasons enunciated up-thread.
>
> Very well - I've just installed the docstring update. Thanks, closing.
>
>
> --- End Message ---