bug#78856: closed (30.1; [PATCH] When navigating to in-page anchors in EWW, 'eww-data' goes missing)

[GNU bug Tracking System]

Your message dated Sun, 22 Jun 2025 09:36:37 -0700
with message-id <e63739ff-4a16-5ed6-9070-81bac8a69d41@gmail.com>
and subject line Re: bug#78856: 30.1; [PATCH] When navigating to in-page 
anchors in EWW, 'eww-data' goes missing
has caused the debbugs.gnu.org bug report #78856,
regarding 30.1; [PATCH] When navigating to in-page anchors in EWW, 'eww-data' 
goes missing
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
78856: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78856
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.1; [PATCH] When navigating to in-page anchors in EWW, 'eww-data' goes missing Date: Sat, 21 Jun 2025 12:22:51 -0700

Steps to reproduce:

  emacs -Q --eval '(eww "https://en.wikipedia.org/wiki/Sun";)'
  RET  ;; Follow the "Jump to content" link at the top of the page
  R    ;; Try to enable readable mode

The result is:

  Wrong type argument: char-or-string-p, nil

That's because when navigating to an in-page anchor, EWW clears 'eww-data', so the :source property is missing. To fix this, let's just copy over all the properties to the new 'eww-data'. That's similar to what we already do when toggling readable mode.

Eli, this bug has been present for quite a while (at least since Emacs 29; I didn't check farther back). It's a simple fix though, so would it be ok to install into Emacs 30? If not, that's not a big deal, and it can just go on the master branch. No one seems to have noticed this bug in the years it's been present.

0001-When-navigating-to-anchor-targets-in-EWW-retain-eww-.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#78856: 30.1; [PATCH] When navigating to in-page anchors in EWW, 'eww-data' goes missing
>
>
>
>
> Date: 
>
> Sun, 22 Jun 2025 09:36:37 -0700
>
>
>
>
> On 6/22/2025 1:20 AM, Eli Zaretskii wrote:
> > Thanks, I'd prefer to install this on master, indeed.
>
> Thanks for taking a look. Merged to the master branch as e5ad9ae1009. 
> Closing this bug now.
>
>
> --- End Message ---