[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: variable selective_display in search.c?

From: Richard Stallman
Subject: Re: variable selective_display in search.c?
Date: Thu, 25 Oct 2001 09:22:48 -0600 (MDT)

    -  int selective_display = (!NILP (current_buffer->selective_display)
    -                          && !INTEGERP 
       /* The code that follows is like scan_buffer
          but checks for either newline or carriage return.  */

It looks like the intention was to test selective_display
in that code.

    This variable is not used now and was never used. Any objection to remove
    it together with this comment

I object to making a change without thinking carefully which change
is the right one.

If the code now does the right thing, then removing the variable is a
reasonable and harmless change.  But there is another possibility:
that the code now does the wrong thing, and must test this variable in
order to do the right thing.

Which one is it?  Only by verifying whether the code is correct
can one decide whether to remove this variable or start using it now.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]