Re: Cast to void* breaks compilation

[Kim F. Storm]

Juanma Barranquero <address@hidden> writes:

> This patch breaks compilation on W2K / Visual C
> 
> 2002-01-02  Richard M. Stallman  <address@hidden>
> 
>         * keyboard.c (read_key_sequence): Handle the keymap property
>         before minor mode maps.
> 
> because of the cast to void*.
> 
>       bcopy (maps, (void *) submaps + nmaps,
>            nminor * sizeof (submaps[0]));
> 
> Perhaps it should be (Lisp_Object *)?

Thanks for spotting this!  The same patch has been responsible for
some traps as well.  I think the proper thing is to write

      bcopy (maps, (void *) (submaps + nmaps),
             nminor * sizeof (submaps[0]));

I've just fixed this in CVS, and emacs no longer traps on me...

-- 
Kim F. Storm <address@hidden> http://www.cua.dk