[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog

From: Pavel Janík
Subject: Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog
Date: Mon, 01 Apr 2002 11:12:05 +0200
User-agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.2.50 (i386-suse-linux-gnu)

[ Redirected to emacs-devel. ]

   From: Richard Stallman <address@hidden>
   Date: Sun, 31 Mar 2002 09:40:15 -0700 (MST)

   >     Richard, play-sound is not guaranteed to exist.
   > Yes, I saw that.
   >     So it is not safe to make play-sound-file unconditional (we can remove
   >     XEmacs comment though).
   > It seems safe to me.  If play-sound is not defined, play-sound-file
   > will get an error trying to call it.  I think that is cleaner behavior
   > than what happens if play-sound-file is not defined at all.

I think it would be much cleaner to:

- Fprovide (intern ("sound"), Qnil) in sound.c when `play-sound' is defined

- use (featurep 'sound) to check if `play-sound' is defined and if it is
  not, provide meaningful error message to the user telling him that his
  Emacs was compiled without sound support

I can do that if you agree with this. I will also add --with[out]-sound to
Pavel Janík

panic("Detected a card I can't drive - whoops\n");
                  -- 2.2.16 drivers/net/daynaport.c

reply via email to

[Prev in Thread] Current Thread [Next in Thread]