emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Support for case sensitive abbrev expansion


From: Miles Bader
Subject: Re: [PATCH] Support for case sensitive abbrev expansion
Date: 26 Jul 2002 17:30:16 +0900

Just some technical comments:

There's no need to add a new field to `struct buffer' for the
`abbrev-case-fold' variable, you can just declare a normal variable
Vabbrev_case_fold using DEFVAR_LISP, and emacs will do the right thing
if a mode makes it buffer-local.  [There are obviously trade-offs, but I
think for something minor like this you shouldn't extend the buffer
structure]

The feature that makes it track `case-fold-search' probably isn't useful
-- I expect that in most cases people will want to retain
case-insensitive searching, even in situations where case-sensitive
abbrevs would be appropriate.  I think you should just initialize the
global value to `nil' for compatibility, and leave it to individual
language modes to set a different buffer-local value.

-Miles
-- 
[|nurgle|]  ddt- demonic? so quake will have an evil kinda setting? one that 
            will  make every christian in the world foamm at the mouth? 
[iddt]      nurg, that's the goal 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]