[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Janitorial issues: Man-getpage-in-background

From: Kai Großjohann
Subject: Re: Janitorial issues: Man-getpage-in-background
Date: Fri, 07 Mar 2003 18:53:51 +0100
User-agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.3.50 (gnu/linux)

Kevin Rodgers <address@hidden> writes:

> Kai Großjohann wrote:
>> The function Man-getpage-in-background uses two different ways to set
>> environment variables:
>> (a) (let ((process-environment (copy-sequence process-environment)))
>>       (setenv "FOO" "bar")
>>       ...)
>> (b) (let ((process-environment (cons "FOO=bar" process-environment)))
>>       ...)
>> It looks really strange to see them both in the same function...
>> Okay to unify?  (I'd choose (a) unless there are objections.)
> Objection!  (I've always wanted to say that :-)
> On the basis of unnecessary cons'ing.

It seems you do not object to the unification, just to my choice of

It seems that setenv does quite a bit of work in addition to consing
stuff onto process-environment.  I'm not sure it is a good idea to
skip using setenv.  Wasn't there a discussion about having setenv do
something additional to frobbing process-environment?  It was some
moons ago.  I'm not talking about the multibyte issue that was
recently mentioned.  Hmmm...
A preposition is not a good thing to end a sentence with.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]