emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: strange change in store_symval_forwarding (data.c)


From: Andreas Schwab
Subject: Re: strange change in store_symval_forwarding (data.c)
Date: Wed, 26 Mar 2003 15:51:53 +0100
User-agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.3.50 (gnu/linux)

Kenichi Handa <address@hidden> writes:

|> Currently, store_symval_forwarding has this code:
|> 
|>      case Lisp_Misc_Buffer_Objfwd:
|>        {
|>          int offset = XBUFFER_OBJFWD (valcontents)->offset;
|>          Lisp_Object type;
|> 
|>          if (! NILP (type) && ! NILP (newval)
|>              && XTYPE (newval) != XINT (type))
|>            buffer_slot_type_mismatch (offset);
|> 
|> Please note that the local variable `type' is used without
|> being initialized.
|> 
|> Previously, the code has this initilization part:
|> 
|>          Lisp_Object type;
|> 
|>          type = PER_BUFFER_TYPE (offset);
|>          if (XINT (type) == -1)
|>            error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
|> 
|> ChangeLog doesn't say anything about this change, but it
|> seems that it was done when this change was installed.

This was changed as part of Stefan's checkin (revision 1.221), which does
not have a ChangeLog entry (yet).

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 N├╝rnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]