emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: skeleton.el _ versus @, a new patch


From: Joe Kelsey
Subject: Re: skeleton.el _ versus @, a new patch
Date: 21 Apr 2003 17:32:44 -0700

On Mon, 2003-04-21 at 06:11, Stefan Monnier wrote:
> > Here is a patch to add - as an alternate skeleton character.  - operates
> > exactly as _ in setting skeleton-point, but does not interact with the
> > region wrapping effects.  This means that @ is completely unaffected and
> > remains as just the method of setting the skeleton-positions.
> > 
> > --- skeleton.el.orig    Sat Jul 14 04:21:08 2001
> > +++ skeleton.el Sun Apr 20 15:44:44 2003
> > @@ -453,7 +453,8 @@
> >         ((eq element '|)
> >          (unless skeleton-modified (pop skeleton)))
> >         ((eq element '@)
> > -        (push (point) skeleton-positions)
> > +        (push (point) skeleton-positions))
> > +       ((eq element '-)
> >          (unless skeleton-point (setq skeleton-point (point))))
> >         ((eq 'quote (car-safe element))
> >          (eval (nth 1 element)))
> 
> I think in that case, we should set skeleton-point unconditionally.

You *really* only want to set it on the first occurrence of the
appropriate character, not the last!

/Joe






reply via email to

[Prev in Thread] Current Thread [Next in Thread]