[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Consolidation of image support in new image.c file.

From: Steven Tamm
Subject: Re: Consolidation of image support in new image.c file.
Date: Wed, 10 Mar 2004 21:57:37 -0800

I also could not bootstrap (or make for that matter): Some code was left lying around macfns.c that defines Qjpeg and the like and sys/stat.h wasn't included in image.c for OSX.

I checked in the following changes that make it compile (don't know if it works yet... still bootstrapping):

*** src/macfns.c.~1.29.~        Wed Mar 10 16:27:13 2004
--- src/macfns.c        Wed Mar 10 21:15:22 2004
*** 4391,4412 ****
    set_frame_fontset_func = x_set_font;
    check_window_system_func = check_mac;

-   Qjpeg = intern ("jpeg");
-   staticpro (&Qjpeg);
-   Qtiff = intern ("tiff");
-   staticpro (&Qtiff);
-   Qgif = intern ("gif");
-   staticpro (&Qgif);
-   Qpng = intern ("png");
-   staticpro (&Qpng);
-   defsubr (&Sclear_image_cache);
-   defsubr (&Simage_size);
-   defsubr (&Simage_mask_p);
    hourglass_atimer = NULL;
    hourglass_shown_p = 0;

*** src/image.c.~1.1.~  Wed Mar 10 16:28:24 2004
--- src/image.c Wed Mar 10 21:39:19 2004
*** 92,97 ****
--- 92,98 ----
  #include <alloca.h>
  #ifdef MAC_OSX
+ #include <sys/stat.h>
  #include <QuickTime/QuickTime.h>
  #else /* not MAC_OSX */
  #include <Windows.h>


On Mar 10, 2004, at 5:40 PM, Kim F. Storm wrote:

[This is sent to emacs-devel with CC to selected team members as the
mailing list is still too slow to be useful].

I have just committed changes which moves/merges/consolidates the
image support code for the X, W32, and MAC platforms into a new file

I have successfully tested this on X (with and without -nw).

I have done as much code review as I can for the W32 and MAC ports,
but I cannot do any actual compilation or testing on those platforms.
So if you can test (and fix :-) it for me, I'd appreciate it.

Kim F. Storm <address@hidden> http://www.cua.dk

reply via email to

[Prev in Thread] Current Thread [Next in Thread]