Re: Several suggestions for image support

[Kim F. Storm]

David Kastrup <address@hidden> writes:

> address@hidden (Kim F. Storm) writes:
> 
> > I have now reworked my line height changes.  
> > 
> > Now, the height of a newline equals the current face height, unless an
> > explicit line-spacing property is present on the newline character.
> > 
> > If the value of the line-spacing property is t, you get the effect of
> > my previous change, i.e. the newline character does not add to the
> > height of the row by itself, but the newline glyph is re-positioned 
> > inside the available row height to make it fully visible (when the
> > cursor is above it).
> > 
> > If the value is an integer, it overrides the value of the frame
> > line-spacing parameter and the (buffer local) value of the line-spacing
> > variable.
> 
> So presumably setting the value to 0 will make the newline have the
> height of a normal space in the line?

With the current code, it will have the height of a space in the
current face, not the default face.

Maybe the functionality should be that newlines are by default
always in the default face height, and the line-spacing property
should not change that.  

Instead, it would be better to have a separate line-height property
which can have values:

        nil -> use default face height (as minimum height)
        t   -> use height of current face
        0   -> use actual line height
        N (integer > 0)  -> use N pixels (as minimum height)
        F (float > 0.0)  -> use F * default face height

I think that would be a much cleaner interface.

> 
> One thing that one should try is to have no surprising changes if the
> newline is turned into a space while keeping its properties:
> re-filling a paragraph will do that.

You can just put the line-spacing (or line-height) property on
the whole paragraph and make it sticky.

-- 
Kim F. Storm <address@hidden> http://www.cua.dk