[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: address@hidden: Speed of all-completions]
From: |
Andreas Schwab |
Subject: |
Re: address@hidden: Speed of all-completions] |
Date: |
Tue, 15 Jun 2004 14:13:44 +0200 |
User-agent: |
Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) |
David Kastrup <address@hidden> writes:
> Andreas Schwab <address@hidden> writes:
>
>> David Kastrup <address@hidden> writes:
>>
>> > Andreas Schwab <address@hidden> writes:
>> >
>> >> This is due to this change:
>> >>
>> >> (Ftry_completion, Fall_completions, Ftest_completion): Bind
>> >> case-fold-search to the value of completion-ignore-case when
>> >> checking completion-regexp-list.
>> >>
>> >> I've checked in a fix that avoids the overhead of specbind when
>> >> completion-regexp-list is empty.
>> >
>> > At the cost of being more expensive when it isn't.
>>
>> Why is it more expensive? The check for CONSP (completion-regexp-list)
>> has to be done anyway, and can be CSE'd by the compiler.
>
> Because you are redoing the binding for every element in the loop,
> while it is needed only once.
I did not change anything in this regard.
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
- address@hidden: Speed of all-completions], Richard Stallman, 2004/06/13
- Re: address@hidden: Speed of all-completions], Andreas Schwab, 2004/06/13
- Re: address@hidden: Speed of all-completions], David Kastrup, 2004/06/14
- Re: address@hidden: Speed of all-completions], Andreas Schwab, 2004/06/15
- Re: address@hidden: Speed of all-completions], David Kastrup, 2004/06/15
- Re: address@hidden: Speed of all-completions],
Andreas Schwab <=
- Re: address@hidden: Speed of all-completions], David Kastrup, 2004/06/15
- Re: address@hidden: Speed of all-completions], Andreas Schwab, 2004/06/15
- Re: address@hidden: Speed of all-completions], David Kastrup, 2004/06/15
- Re: address@hidden: Speed of all-completions], Andreas Schwab, 2004/06/15
- Re: address@hidden: Speed of all-completions], David Kastrup, 2004/06/15
- Re: address@hidden: Speed of all-completions], Andreas Schwab, 2004/06/15
- Re: address@hidden: Speed of all-completions], Luc Teirlinck, 2004/06/15
- Re: address@hidden: Speed of all-completions], David Kastrup, 2004/06/15
- Re: address@hidden: Speed of all-completions], Luc Teirlinck, 2004/06/18
- Re: address@hidden: Speed of all-completions], Richard Stallman, 2004/06/18