[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Delayed loading of image libraries

From: Juanma Barranquero
Subject: Re: [PATCH] Delayed loading of image libraries
Date: Wed, 30 Jun 2004 15:00:30 +0200

On Wed, 30 Jun 2004 13:41:51 +0200
Andreas Schwab <address@hidden> wrote:

> Would Qnil be valid in this context?  Certainly for !HAVE_NTGUI, but would
> that work for HAVE_NTGUI?

Passing Qnil should work.  However, Miles' change doesn't seem to be
right, even when passing Qnil to Finit_image_library.  make_image does:

  img->type = lookup_image_type (image_spec_value (spec, QCtype, NULL));
  xassert (img->type != NULL);

and, from what I gather, xassert can be a null op**, in which case an
image is built with a non-valid type.

In fact, I'm not sure why lookup_image_type is supposed to allow
returning NULL.  It is an internal function to map image type symbols to
image type structs, so the image type symbol validation should be done
at a higher level (before calling lookup_image_type).

**BTW, what is xassert supposed to do?  On dispextern.h it is a null op
unless GLYPH_DEBUG is defined; and fontset.c has its own definition.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]