[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix `window-at' and `coordinates-in-window-p'

From: Lőrentey Károly
Subject: Re: [PATCH] Fix `window-at' and `coordinates-in-window-p'
Date: Sun, 25 Jul 2004 22:52:49 +0200
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux)

Richard Stallman <address@hidden> writes:
>     I think it's easier to adjust the pixel coordinates right inside
>     coordinates_in_window_p, which both functions use:
> This is not clean, because it gives the arguments of
> coordinates_in_window_p a peculiar meaning (and doesn't document it,
> by the way).  It is much better to keep their meanings consistent
> with the rest of Emacs.


> I will fix the other call.

If you mean the one in window-vscroll, I don't think there are
problems with that in CVS.  (It uses the macros for converting
relative lengths, as intended.  My patch would have broken that.)

> Meanwhile, I fixed the other reported bug in coordinates-in-window-p.

Great! :-)


Attachment: pgpSQJuTWzkVE.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]