[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
address@hidden: url libraries can reult in destruction of wrong buffer a
address@hidden: url libraries can reult in destruction of wrong buffer after 401]
Mon, 01 Nov 2004 02:23:39 -0500
[I sent this message a few week ago but did not get a response.
This needs to be looked at]
Could someone take a look at what to do here? I am not sure
whether this is still relevant--his suggestion seems to assume that
url-http-handle-authentication returns a new buffer, but it does not
appear to do that now.
Would someone please DTRT and ack to me?
------- Start of forwarded message -------
From: Vivek Dasmohapatra <address@hidden>
Date: Tue, 28 Sep 2004 16:13:13 +0100
X-Scanner: exiscan *1CCJfG-0000T2-00*YBhr5NphPPU* (Zeus Technology Ltd)
Subject: url libraries can reult in destruction of wrong buffer after 401
X-Spam-Status: No, hits=0.5 required=5.0
X-Spam-Checker-Version: SpamAssassin 2.55 (220.127.116.11-2003-05-19-exp)
This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.
Your bug report will be posted to the address@hidden mailing list,
and to the gnu.emacs.bug news group.
In GNU Emacs 21.3.1 (i386-pc-linux-gnu, X toolkit)
of 2004-08-26 on nessus, modified by Debian
configured using `configure '--build=i386-linux' '--host=i386-linux'
'--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
'--mandir=/usr/share/man' '--with-pop=yes' '--with-x=yes'
'--with-x-toolkit=athena' '--without-toolkit-scroll-bars' 'CFLAGS=-DDEBIAN -g
-O2' 'build_alias=i386-linux' 'host_alias=i386-linux''
value of $LC_ALL: nil
value of $LC_COLLATE: ja_JP
value of $LC_CTYPE: ja_JP
value of $LC_MESSAGES: en_GB
value of $LC_MONETARY: en_GB
value of $LC_NUMERIC: en_GB
value of $LC_TIME: en_GB
value of $LANG: ja_JP
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
Fetching a url with url-retrieve can reult in an anrbitrary buffer
being killed if a 401 (or possibly a 407) result is encountered:
url-http-parse-headers calls url-http-handle-authentication,
which can call url-retrieve.
This results in the current buffer being killed, and a new http buffer
being generated. However, when the old http buffer is killed, emacs
picks the top buffer from the list as the new current buffer, so by the
time we get to the end of url-http-parse-headers, _that_ buffer is marked
as dead even though it is not necessarily a url buffer, so next time the
url libraries reap their dead buffers, an innocent bystander buffer is
killed instead (and an obsolete http buffer may be left lying around too).
A possible fix (which I am currently using) is to call set-buffer
on the return value of url-http-parse-headers:
;; The request requires user authentication. The response
;; MUST include a WWW-Authenticate header field containing a
;; challenge applicable to the requested resource. The
;; client MAY repeat the request with a suitable
;; Authorization header field.
(set-buffer (url-http-handle-authentication nil)))
which makes sure that it is the right http buffer that is current when
we come to mark the http buffers as dead.
Bug-gnu-emacs mailing list
------- End of forwarded message -------
|[Prev in Thread]
||[Next in Thread]|
- address@hidden: url libraries can reult in destruction of wrong buffer after 401],
Richard Stallman <=