[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: intern-soft, find-face/get-face, and facep for determining faces' de

From: Stephen J. Turnbull
Subject: Re: intern-soft, find-face/get-face, and facep for determining faces' definedness
Date: Thu, 04 Nov 2004 18:28:03 +0900
User-agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.5 (chayote, linux)

>>>>> "Zajcev" == Zajcev Evgeny <address@hidden> writes:

    Zajcev> Andreas Schwab <address@hidden> writes:

    >> Zajcev Evgeny <address@hidden> writes:

    >>> Most of functions that deal with faces should use `(facep
    >>> (get-face <face>))' sexp to check face validity.

    >> Why do you need facep if get-face already did all validation?

XEmacs doesn't need facep.  facep is useful in very few contexts, and
this isn't one of them.

    Zajcev> Oh yes, it should be one of: `(get-face <face>)' or
    Zajcev> `(facep (find-face <face>))' to avoid signals.

In XEmacs (facep (find-face ...)) is redundant.  It merely turns a
useful value (a face, which is just as true as t) into t.

There's no theoretical reason why would we couldn't sync to the Emacs
API, with faces being symbols registered as faces, no more and no
less.  However, in practice verifying it does no harm would be a lot
of work, and I don't see a benefit to it.  OTOH, adding the find-face
API to Emacs is trivial and can't do harm to existing code, although
it's really not necessary at all in Emacs AFAICS.  It's a minor
convenience in the code the OP posted, of course, but you could just
as easily inline Miles's implementation.

I don't see need for further discussion of XEmacs APIs on emacs-devel,
and I know y'all are quite busy right now.  So this is my last post in
this thread to emacs-devel (although I will continue to monitor it).
I will respond to further posts as appropriate, but (unless requested)
only on xemacs-beta.


Institute of Policy and Planning Sciences     http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba                    Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
               Ask not how you can "do" free software business;
              ask what your business can "do for" free software.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]