[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: VM and find-face

From: Miles Bader
Subject: Re: VM and find-face
Date: Fri, 7 Jan 2005 07:11:46 +0900

I sent this message to a different mailing list:

On Thu, 06 Jan 2005 15:05:57 +0000, Glenn Morris
<address@hidden> wrote:
> The new function find-face is incompatible with the XEmacs version,
> and therefore breaks existing package code that tries to handle both
> Emacs flavours.
> The GNU Emacs version throws an error for an unknown face:
> (find-face 'made-up-face)

Yes, the new function `find-face' appears to be a completely different
function than the xemacs `find-face' function; it seems to be an
analogue to `find-function', for finding the source code definition of
a face.

I'm not sure that this is all that useful a function anyway -- the
source code of a defface doesn't really offer much over the face
definition displayed by custom or the like; unlike a function or
variable, defface definitions are almost always "static" (don't use a
run-time calculated value) and rarely have any comments. 
Compatibility with xemacs seems more important.

Perhaps the function could be renamed `find-defface' or
`find-face-definition' instead; those names are slightly inconsistent
with other such functions, but maybe it doesn't matter very much for a
function that will likely be used mostly by clicking on a button in a
*Help* buffer.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]