[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch to fix frame positioning bug on Windows with (make-frame '((le
Re: Patch to fix frame positioning bug on Windows with (make-frame '((left . -1)))
Wed, 12 Jan 2005 21:04:56 +0100
Using Emacs built from CVS source code on Windows XP, the frame created
using the following Emacs-Lisp code is positioned such that the
rightmost 7 pixels of the frame are off the right edge of the screen:
(make-frame '((width . 80) (height . 20) (top . 0) (left . -1)))
Those 7 pixels encompass the border of the Windows frame and some of
right fringe. This may have been caused by revision 1.220 of w32term.c
in which function x_calc_absolute_position() was changed:
date: 2004/12/11 21:12:45; author: jhd; state: Exp; lines: +0 -30
* w32term.c (x_calc_absolute_position): Remove calculation of
difference between inner and outer window. Don't subtract difference
for left and top calculations.
The below patch solves the problem but it may not be optimal because it
simply subtracts 7 from the computed value of f->left_pos.
Can you verify if your change has any impact on this bug:
This was the reason a change was made. It may be impossible to get
Emacs to work correctly on W32. Just adding 7 is no good, as you self
pointed out, a more general solution must be found.