[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: xassert in dispextern.h

From: Kim F. Storm
Subject: Re: xassert in dispextern.h
Date: Wed, 02 Mar 2005 00:14:40 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Miles Bader <address@hidden> writes:

> The right answer is to change those xasserts (and _only_ those) which
> cause a problem or test something silly or are insanely inefficient
> [99% are quite efficient] to use some other macro, like "gdassert" or
> something, and make gdassert dependent on GLYPH_DEBUG.

If that is the _right_ answer, and it is as simple as you claim, 
would _you_ please start to identify and change those 1% of the
xasserts which cause a problem, test something silly, or are
insanely inefficient.

Or do you still expect _me_ to do that?

I don't recall _you_ asking if I (or anyone else) really had time for
this "xassert-triggered bug hunting"....

> [I should note that the thing which caused me to originally enable
> xassert by default is that it caught (I always have it enabled) a case
> where iterator stacks could overflow -- something that otherwise would
> just result in rare, hard to debug, memory corruption.]

That's right -- it was a mistake I had made a few days earlier -- not
some tricky old but that took hours of debugging to realize that it
was just a silly test...

I'll suggest that we leave the xassert in there for 2 more weeks --
just in case something serious pops up -- and then remove them again
and focus on finishing the release.

Kim F. Storm <address@hidden> http://www.cua.dk

reply via email to

[Prev in Thread] Current Thread [Next in Thread]