[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fileio.c "#if 0" block

From: Thien-Thi Nguyen
Subject: Re: fileio.c "#if 0" block
Date: Sun, 06 Mar 2005 02:25:11 +0100

   From: "Eli Zaretskii" <address@hidden>
   Date: Sat, 05 Mar 2005 19:20:17 +0200

   Given this very clear (IMHO) explanation, I don't understand your
   original gripe about it: [...] Can you explain what you meant by
   that, now that you know why the old code was left in the sources,
   rather than deleted?

as part of the emacs under vms effort, i'm addressing some of the
"subtle bugs" (that are related to vms) in Fexpand_file_name, by
studying the current behavior, forming a mental model of the correct
behavior and making the necessary changes.  for completeness, i would
prefer to apply these bugfixes to all instances of the bug that i can
find, whether in one function or in many.

i get the feeling that modifying the #if-0'ed out Fexpand_file_name,
however, goes against the intent of preserving it in some kind of
pristine form.  i can see a value in leaving it completely untouched as
a historical snapshot (certainly, it is less work to completely ignore
it).  my griping was an expression of inner conflict at allowing bit rot
to flourish unchecked, and not completing the job in some sense.

but having written this, i've overcome that internal conflict (laziness
wins) -- i'll leave that code alone for someone else to munge, and work
on something else.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]