[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Hourglass only for X-windows?

From: Lennart Borgman
Subject: Re: Hourglass only for X-windows?
Date: Fri, 11 Mar 2005 00:33:16 +0100

----- Original Message ----- 
From: "Lennart Borgman" <address@hidden>

> ----- Original Message ----- 
> From: "Eli Zaretskii" <address@hidden>

> > > I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I
> > > believe most would like better - but not I) replacing them with
> something
> > > like
> > >
> > >     #ifdef HAS_HOURGLASS
> >
> > We cannot do the former without adding (possibly empty) functions
> > called by those snippets to all ports.  And we cannot do the latter
> > without adding some configury stuff that would determine the value of
> > HAS_HOURGLASS at configure time.
> >
> > Personally, I think we are fine as we are now.  Of course, if you
> > implement start_hourglass et al for Windows, the HAVE_X_WINDOWS
> > condition needs to be augmented by something that will enable it for
> > Windows.
> Yes, I thought I would implement start_hourglass etc.  Maybe someone wants
> to implement it in macfns.c too where the body part also has an empty body
> part.
> Whichever way of changing the current "#ifdef HAVE_X_WINDOWS" at those
> places are enough, but removing the ifdef:s and adding a file with empty
> body parts for those ports that does not implement hourglass support makes
> the code easier to read IMO.

I have implemented code for hourglass on w32 now (or rather I should say
Dave Hunter has done it, I just did a small amount of typing). Could we
please get a decision on the issue above so that it is possible to get this
working with the CVS code? (The hourglass code in keyboard.c is currently
only called if HAVE_X_WINDOWS is defined.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]