[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: isearch-forward and Info-search

From: Nick Roberts
Subject: Re: isearch-forward and Info-search
Date: Mon, 14 Mar 2005 10:15:18 +1300

 > > The implementation looks clean.  I just suggest that we should simply
 > > replace isearch-invalid-regexp with isearch-error (there can only be one
 > > error at any given time, either a search failure or an invalid regexp, or
 > > ...).
 > OK.
 > I also removed `isearch-within-brackets' because it is used nowhere
 > within Emacs.  And added `condition-case' around the call to
 > `isearch-search-fun' in `isearch-lazy-highlight-search' to return nil
 > in case of error which allows `isearch-lazy-highlight-update' to try to
 > highlight matches from the window beginning (needed for Info isearch).

I like the way this works. Thanks for fixing it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]