[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Carbon port: setting the creator code (patch)

From: David Reitter
Subject: Re: Carbon port: setting the creator code (patch)
Date: Sun, 10 Jul 2005 12:55:01 +0100

On 10 Jul 2005, at 01:56, YAMAMOTO Mitsuharu wrote:

I think these functions should follow the convention of existing
operations on files.  For example, with respect to the default
directory, error handling, and argument names.  Maybe the function
name should be "mac-set-file-creator".  We can additionally think of
"mac-file-creator" and "mac-file-type", or "mac-file-attributes" for
reading these kinds of information.

OK, what I have now is

(mac-set-file-creator filename &optional code)
(mac-set-file-type filename type)

They throw errors if code or type or filename are bad.

And more importantly, please care about BLOCK_INPUT when adding new C
functions.  It required much effort to fill missing BLOCK_INPUTs that
had been a cause of unstability in the Carbon port.

OK, done. Hope I got that right.

The new patch is enclosed.

Attachment: mac-set-creator.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]