[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Code inspection: W32 specific problems

From: Eli Zaretskii
Subject: Re: Code inspection: W32 specific problems
Date: Sat, 16 Jul 2005 14:32:20 +0300

> From: address@hidden (Kim F. Storm)
> Date: Tue, 12 Jul 2005 14:44:06 +0200
> Code inspection revealed the following w32 specific problems:
> - Qhigh and Qlow have no staticpro.
> - Vw32_valid_codepages has no staticpro.
> - Vw32_valid_locale_ids has no staticpro.
> - Qw32_charset_default is never initialized, but its value
>   is used in two places.
> - Vx_hand_shape is declared, but never initialized or used.
> Can someone pls. look at this and fix the problems, or
> alternatively specify why staticpro's are not needed.

Thanks.  I added staticpro for the first 4 variables.

As for Qw32_charset_default and Vx_hand_shape, someone with more
knowledge in the w32 code than myself should look at this.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]