Re: battery.el: Rename display-battery-mode to battery-mode?

[Lute Kamstra]

Reiner Steib <address@hidden> writes:

> I tried to enable battery-mode on my notebook using `M-x battery- TAB'
> but I got "No match".  Eventually I found `display-battery-mode' in
> `battery.el'.  Shouldn't the name of the minor mode read
> `battery-mode' instead of `display-battery-mode'?

Agreed.

> --8<---------------cut here---------------start------------->8---
> --- battery.el        17 Jul 2005 19:58:18 +0200      1.28
> +++ battery.el        02 Aug 2005 17:59:51 +0200      
> @@ -131,7 +131,7 @@
>                 "Battery status not available")))
>  
>  ;;;###autoload
> -(define-minor-mode display-battery-mode
> +(define-minor-mode battery-mode
>    "Display battery status information in the mode line.
>  The text being displayed in the mode line is controlled by the variables
>  `battery-mode-line-format' and `battery-status-function'.
> @@ -149,6 +149,8 @@
>                                           'battery-update-handler))
>      (battery-update)))
>  
> +(define-obsolete-function-alias 'display-battery-mode 'battery-mode "22.1")
> +
>  (defun battery-update-handler ()
>    (battery-update)
>    (sit-for 0))
> --8<---------------cut here---------------end--------------->8---
>
> Okay to commit?

Ok with me.

> Shouldn't battery mode be mentioned briefly in (info "(emacs)Optional
> Mode Line") as well?

Maybe you can write a patch?

Lute.