Suggestion: go to bottom of mail message

[Ehud Karni]

[this is resend because the attached patch had the files reversed]

On 2003-11-19 I suggested some change to mail/rmailsum.el (see -
http://lists.gnu.org/archive/html/emacs-devel/2003-11/msg00279.html )
that got a supporting opinion from Kenichi Handa (see -
http://lists.gnu.org/archive/html/emacs-devel/2003-11/msg00270.html ).
I don't have write permission to CVS and nobody else added it.
Here it is again (diff against the latest CVS versions), in the hope
that it will included in Emacs 22.1.

Ehud.


2003-11-19  Ehud Karni  <address@hidden>

        * mail/rmailsum.el (rmail-summary-end-of-message): New command
        to go to the bottom of the mail message. Added to
        `rmail-summary-mode-map' with key "/".
        (rmail-summary-show-message) New (internal) function for use by
        both `rmail-summary-beginning/end-of-message'.
        (rmail-summary-beginning-of-message) Changed to use the new
        function.

        * mail/rmail.el (rmail-end-of-message): New command to go to the
        end of the current message. Added to `rmail-mode-map' with key "/".
        (rmail-beginning-of-message): Fixed to work as documented.
        (rmail-mode): change documentation.


diff -c rmailsum.el.~1.135.~ rmailsum-new.el
*** rmailsum.el.~1.135.~        Mon Jul 11 19:05:43 2005
--- rmailsum-new.el     Sat Aug  6 12:30:10 2005
***************
*** 898,903 ****
--- 898,904 ----
    (define-key rmail-summary-mode-map "x"      'rmail-summary-expunge)
    (define-key rmail-summary-mode-map "w"      'rmail-summary-output-body)
    (define-key rmail-summary-mode-map "."      
'rmail-summary-beginning-of-message)
+   (define-key rmail-summary-mode-map "/"      'rmail-summary-end-of-message)
    (define-key rmail-summary-mode-map "<"      'rmail-summary-first-message)
    (define-key rmail-summary-mode-map ">"      'rmail-summary-last-message)
    (define-key rmail-summary-mode-map " "      'rmail-summary-scroll-msg-up)
***************
*** 1185,1190 ****
--- 1186,1201 ----
  (defun rmail-summary-beginning-of-message ()
    "Show current message from the beginning."
    (interactive)
+   (rmail-summary-show-message 'BEG))
+
+ (defun rmail-summary-end-of-message ()
+   "Show bottom of current message."
+   (interactive)
+   (rmail-summary-show-message 'END))
+
+ (defun rmail-summary-show-message (where)
+   "Show current mail message.
+ Position it according to WHERE which can be BEG or END"
    (if (and (one-window-p) (not pop-up-frames))
        ;; If there is just one window, put the summary on the top.
        (let ((buffer rmail-view-buffer))
***************
*** 1196,1203 ****
        (or (eq buffer (window-buffer (next-window (frame-first-window))))
            (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (with-no-warnings
!     (beginning-of-buffer))
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()
--- 1207,1220 ----
        (or (eq buffer (window-buffer (next-window (frame-first-window))))
            (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (cond
!    ((eq where 'BEG)
!       (goto-char (point-min))
!       (search-forward "\n\n"))
!    ((eq where 'END)
!       (goto-char (point-max))
!       (recenter (1- (window-height))))
!    )
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()



diff -c rmail.el.~1.406.~ rmail-new.el
*** rmail.el.~1.406.~   Mon Jul 11 19:05:42 2005
--- rmail-new.el        Sat Aug  6 13:41:01 2005
***************
*** 952,957 ****
--- 952,958 ----
    (define-key rmail-mode-map "w"      'rmail-output-body-to-file)
    (define-key rmail-mode-map "x"      'rmail-expunge)
    (define-key rmail-mode-map "."      'rmail-beginning-of-message)
+   (define-key rmail-mode-map "/"      'rmail-end-of-message)
    (define-key rmail-mode-map "<"      'rmail-first-message)
    (define-key rmail-mode-map ">"      'rmail-last-message)
    (define-key rmail-mode-map " "      'scroll-up)
***************
*** 1096,1102 ****
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]        Move point to front of this message 
(same as \\[beginning-of-buffer]).
  \\[scroll-up] Scroll to next screen of this message.
  \\[scroll-down]       Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]      Move to Next non-deleted message.
--- 1097,1104 ----
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]        Move point to front of this message.
! \\[rmail-end-of-message]      Move point to bottom of this message.
  \\[scroll-up] Scroll to next screen of this message.
  \\[scroll-down]       Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]      Move to Next non-deleted message.
***************
*** 2604,2610 ****
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (rmail-show-message rmail-current-message))

  (defun rmail-unknown-mail-followup-to ()
    "Handle a \"Mail-Followup-To\" header field with an unknown mailing list.
--- 2606,2624 ----
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (let ((rmail-show-message-hook
!        (list (function (lambda ()
!                          (goto-char (point-min)))))))
!     (rmail-show-message rmail-current-message)))
!
! (defun rmail-end-of-message ()
!   "Show bottom of current message."
!   (interactive)
!   (let ((rmail-show-message-hook
!        (list (function (lambda ()
!                          (goto-char (point-max))
!                          (recenter (1- (window-height))))))))
!     (rmail-show-message rmail-current-message)))

  (defun rmail-unknown-mail-followup-to ()
    "Handle a \"Mail-Followup-To\" header field with an unknown mailing list.



--
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry