[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Options menu is broken on CVS

From: Stefan Monnier
Subject: Re: Options menu is broken on CVS
Date: Thu, 08 Sep 2005 17:02:05 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

>> Perhaps the best way to find out what the bug was is to revert the
>> change; then someone will see that bug again, and someone can write a
>> new fix for it.

> No, this is IMHO a bad way: the chances of that someone to see that
> bug could be small, depending on what was the configuration in which
> it was found back then.  It is much better to read the emacs-devel
> discussions related to my change and understand what was the bug I
> fixed.

Let's take it as a reminder that when we commit a fix, we should make sure
we describe the bug it fixes, either in comments in the code (when
possible/meaningful) or in the ChangeLog entry.  Of course, if the old code
was just plain wrong it's not necessary.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]