[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Starnge comment in Custom Theme code.
From: |
Chong Yidong |
Subject: |
Re: Starnge comment in Custom Theme code. |
Date: |
Sat, 24 Dec 2005 12:21:47 -0500 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
Luc Teirlinck <address@hidden> writes:
> What does the following comment starting on line 679 of custom.el
> mean? I believe that we decided that a theme should never override a
> value defined with setq or otherwise set outside Custom. So the user
> value does not have to "come back", it never goes away.
>
> ;; Add a new setting.
> ;; If the user changed the value outside of Customize, we
> ;; first save the current value to a fake theme, `standard'.
> ;; This ensures that the user-set value comes back if the
> ;; theme is later disabled.
I don't know where "we" decided that, but I wrote that part at
Richard's request.
> What does the code that follows the comment do? Nobody will ever find
> bugs in the Themes code by using it, because nobody is using it. So
> the only way to find bugs is to read the source code and see what it
> does. Did anybody ever do that? I tried and concluded that it was
> just an incoherent bunch of nonsense, that was not worth trying to fix.
I don't know how many people are using the Themes code, but it is
pretty understandable to me (and I wasn't even the original author).
I don't know what your belly-aching is supposed to accomplish; if
you're suggesting to rewrite the Custom Themes code, it's rather too
late in the release process for that.
- Starnge comment in Custom Theme code., Luc Teirlinck, 2005/12/24
- Re: Starnge comment in Custom Theme code.,
Chong Yidong <=
- Re: Starnge comment in Custom Theme code., Luc Teirlinck, 2005/12/24
- Re: Starnge comment in Custom Theme code., Luc Teirlinck, 2005/12/24
- Re: Starnge comment in Custom Theme code., Richard M. Stallman, 2005/12/25
- Re: Starnge comment in Custom Theme code., Luc Teirlinck, 2005/12/25
- Re: Starnge comment in Custom Theme code., Richard M. Stallman, 2005/12/26