[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Risky local variable mechanism

From: Richard M. Stallman
Subject: Re: Risky local variable mechanism
Date: Sat, 11 Feb 2006 11:44:10 -0500

What you've implemented is the sort of thing I had in mind.
It seems basically right.  Here are a few comments on minor details.

    !   (or (= char ?!)
    !       (= char ? )

It would be better to use \s.

    + (defcustom safe-local-variables nil

I would call it safe-local-variable-values.

    +   "Alist of safe local variables.

It is not really an alist.  In an alist, the car of an element
is a key, so only the first element with a given car really counts.
This is a list of variable-value pairs.

    +   :type  'alist)

It is ok to use `alist' as the custom type if it gives the right
results in the custom buffer, as it seems to do.
But it might be cleaner to do this another way just to avoid
misleading someone.

By the way, this variable should be marked risky.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]