[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Error in add-log-iso8601-time-string

From: Stefan Monnier
Subject: Re: Error in add-log-iso8601-time-string
Date: Wed, 26 Apr 2006 12:42:06 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

> Unless I'm misundertanding something (likely, as the flu is getting
> the better of me), the recent patch to `add-log-iso8601-time-string'
> is flawed:

>  (defun add-log-iso8601-time-string ()
>    (let ((time (format-time-string "%Y-%m-%d" (eq t add-log-time-zone-rule))))
>      (if add-log-iso8601-with-time-zone
>          (concat time " " (add-log-iso8601-time-zone))
>        time)))

> On one hand, when `add-log-time-zone-rule' is t (possible, according
> to its docstring), `format-time-string' receives t as second argument,
> which is an error:

ELISP> (format-time-string "%Y-%m-%d" t)
>  *** Eval error ***  Wrong type argument: listp, t

> On the other hand, `add-log-iso8601-time-zone has a mandatory TIME
> argument which is lacking here.

Thanks.  It should be fixed now,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]