[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Displaying MIME parts internally/externally in Gnus
From: |
Reiner Steib |
Subject: |
Re: Displaying MIME parts internally/externally in Gnus |
Date: |
Thu, 04 May 2006 14:43:51 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) |
On Thu, May 04 2006, Stefan Monnier wrote:
>> In `mm-inlinable-p', TYPE is the value of (mm-handle-media-type handle):
> [...]
>> Stefan, maybe you forgot to send a patch for `mm-decode.el' as well?
>
> Oops, looks like you're right. The patch is the obvious one.
Thanks. Could you provide a ChangeLog entry, please? AFAICS, the
first two hunks are unrelated (maybe the ChangeLog entry will
clarify).
For the `gnus-art.el' changes, I've added the following. Feel free to
suggest a better entry.
--8<---------------cut here---------------start------------->8---
2006-05-03 Stefan Monnier <address@hidden>
* gnus-art.el (gnus-mime-view-part-as-type): Add optional PRED
argument.
(gnus-mime-view-part-externally, gnus-mime-view-part-internally):
Try harder to show the attachment internally or externally using
gnus-mime-view-part-as-type.
--8<---------------cut here---------------end--------------->8---
> @@ -1019,10 +1017,10 @@
> methods nil)))
> result))
>
> -(defun mm-inlinable-p (handle)
> +(defun mm-inlinable-p (handle &optional type)
> "Say whether HANDLE can be displayed inline."
> + (unless type (setq type (mm-handle-media-type handle)))
> (let ((alist mm-inline-media-tests)
> - (type (mm-handle-media-type handle))
> test)
> (while alist
> (when (string-match (caar alist) type)
IMHO, the doc string should explain the use of TYPE, i.e. if TYPE is
given, HANDLE is ignored.
BTW, I did some test with *.pdf and *.png files attached as
application/octet-stream. Using `e', I get "View as MIME type
(default image/png)" but TAB doesn't offer me any completion.
Maybe an addition to (info "(gnus)Using MIME") for `e' and `E' would
be useful.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/