[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
C-f in isearch minibuffer (was: should search ring contain duplicates?)
From: |
Juri Linkov |
Subject: |
C-f in isearch minibuffer (was: should search ring contain duplicates?) |
Date: |
Thu, 11 May 2006 14:59:03 +0300 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) |
> I think this is a good idea. This would help to get rid of a new
> useless argument `keep-all' added a few months ago to the function
> `read-from-minibuffer' only for the sake of query-replace.
> Since query-replace is the only place in Emacs that uses this new argument,
> it is better to remove it now before the release, and to use a new
> macro `history-push' in `query-replace-read-to' to treat the query-replace
> history specially.
This reminds me of another misfeature. C-f typed at the end of the
isearch's minibuffer that pulls characters from the parent buffer is
not user-friendly. With recently proposed special commands like `M-.'
in the minibuffer to pull things from the parent buffer to be implemented
in the next release, I think it is better to get rid of this misfeature
before this release:
Index: lisp/isearch.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/isearch.el,v
retrieving revision 1.288
diff -c -r1.288 isearch.el
*** lisp/isearch.el 5 May 2006 23:37:31 -0000 1.288
--- lisp/isearch.el 11 May 2006 11:55:45 -0000
***************
*** 418,425 ****
(define-key map "\M-\t" 'isearch-complete-edit)
(define-key map "\C-s" 'isearch-forward-exit-minibuffer)
(define-key map "\C-r" 'isearch-reverse-exit-minibuffer)
- (define-key map "\C-f" 'isearch-yank-char-in-minibuffer)
- (define-key map [right] 'isearch-yank-char-in-minibuffer)
map)
"Keymap for editing isearch strings in the minibuffer.")
--- 418,423 ----
***************
*** 1322,1338 ****
(goto-char isearch-other-end))
(buffer-substring-no-properties (point) (funcall jumpform)))))
- (defun isearch-yank-char-in-minibuffer (&optional arg)
- "Pull next character from buffer into end of search string in minibuffer."
- (interactive "p")
- (if (eobp)
- (insert
- (save-excursion
- (set-buffer (cadr (buffer-list)))
- (buffer-substring-no-properties
- (point) (progn (forward-char arg) (point)))))
- (forward-char arg)))
-
(defun isearch-yank-char (&optional arg)
"Pull next character from buffer into search string."
(interactive "p")
--- 1341,1346 ----
--
Juri Linkov
http://www.jurta.org/emacs/
- Re: query-replace in isearch (was Re: should search ring contain duplicates?), (continued)
- Re: should search ring contain duplicates?, Juri Linkov, 2006/05/09
- Re: should search ring contain duplicates?, Kim F. Storm, 2006/05/10
- Re: should search ring contain duplicates?, Juri Linkov, 2006/05/10
- Re: should search ring contain duplicates?, Kim F. Storm, 2006/05/11
- Re: should search ring contain duplicates?, Richard Stallman, 2006/05/14
- Re: should search ring contain duplicates?, Kim F. Storm, 2006/05/15
- Re: should search ring contain duplicates?, Richard Stallman, 2006/05/16
- Re: should search ring contain duplicates?, Kim F. Storm, 2006/05/16
- C-f in isearch minibuffer (was: should search ring contain duplicates?),
Juri Linkov <=
- Re: C-f in isearch minibuffer, Miles Bader, 2006/05/11
- Re: C-f in isearch minibuffer, Juri Linkov, 2006/05/11
- Re: C-f in isearch minibuffer (was: should search ring contain duplicates?), Richard Stallman, 2006/05/12
- Re: C-f in isearch minibuffer, Juri Linkov, 2006/05/12
- Re: C-f in isearch minibuffer, Richard Stallman, 2006/05/13
Re: should search ring contain duplicates?, Stefan Monnier, 2006/05/03