[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Semantics of autoload cookies on defcustoms

From: Stefan Monnier
Subject: Re: Semantics of autoload cookies on defcustoms
Date: Mon, 10 Jul 2006 12:12:20 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

>     -              (if (equal setter ''custom-set-minor-mode)
>     -                  `(put ',varname 'custom-set 
> 'custom-set-minor-mode))))))

> I think it would be incorrect to delete those two lines.  In the
> existing code, that `put' call is output in addition to the
> `custom-autoload' call.  With your change, only the `custom-autoload'
> call would be output in that case.

> I am pretty sure we added that `put' call a few months ago to fix a bug.
> Deleting it would bring back the bug.

Actually, I don't think so.  I added that put because I thought it was
necessary when we removed the use of the :require property from
define-minor-mode.  But I didn't know about this custom-autoload back then.
AFAICT the custom-autoload already solves the problem and this `put' was
redundant from the start.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]