[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: jit-lock timer etc.

From: martin rudalics
Subject: Re: jit-lock timer etc.
Date: Thu, 24 Aug 2006 18:18:31 +0200
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

 I don't know what was wrong with this code since you didn't post it.
> It looks like you simply forgot to initialize jit-lock-stealth-repeat-timer,
> but I can't be sure.

As suggested by rms for his resume timer I did in `jit-lock-mode':

         (when (and jit-lock-stealth-time (null jit-lock-stealth-timer))
           (setq jit-lock-stealth-timer
                 (run-with-idle-timer jit-lock-stealth-time t
         (when (and jit-lock-stealth-time (null jit-lock-stealth-repeat-timer))
           (setq jit-lock-stealth-repeat-timer (timer-create))
           (timer-set-function jit-lock-stealth-repeat-timer
                               'jit-lock-stealth-fontify t))

> However, the following patch, based on the last
> patch you posted to this list with minimal modifications, works fine
> for me.
> It applies to the current CVS tree, and uses `current-idle-time'.  It
> includes and uses the change to `timer-set-idle-time' which I
> previously posted, allowing it to accept the value returned by
> `current-idle-time'.

Is this Richard's or Kim's version of `current-idle-time'.

> I have verified that the idle timer triggers correctly, stops
> correctly when user input comes in, and resumes when Emacs becomes
> idle again.
> *** emacs/lisp/jit-lock.el.~1.54.~ 2006-08-17 11:49:36.000000000 -0400
> --- emacs/lisp/jit-lock.el 2006-08-24 11:21:23.000000000 -0400
> !    (setq jit-lock-stealth-repeat-timer
> !          (run-at-time delay
> !                       nil 'jit-lock-stealth-fontify t)))))))

Richard told me not to use `run-at-time' - well it's for the first time
only - but I'll have to justify why I can't `run-with-idle-time' here.

>   (defun timer-set-idle-time (timer secs &optional repeat)
>     "Set the trigger idle time of TIMER to SECS.
> + SECS may be an integer, floating point number, or the internal
> + time format (HIGH LOW USECS) returned by, e.g., `current-time'.
>   If optional third argument REPEAT is non-nil, make the timer
>   fire each time Emacs is idle for that many seconds."
>     (or (timerp timer)
>         (error "Invalid timer"))
> !   (if (consp secs)
> !       (progn (aset timer 1 (car secs))
> !       (aset timer 2 (if (consp (cdr time)) (car (cdr time)) (cdr time)))
> !       (aset timer 3 (or (and (consp (cdr time)) (consp (cdr (cdr time)))
> !                              (nth 2 time))
> !                         0)))
> !     (aset timer 1 0)
> !     (aset timer 2 0)
> !     (aset timer 3 0)
> !     (timer-inc-time timer secs))
>     (aset timer 4 repeat)
>     timer)

Did you compile that?  `time' in here gets me:

In timer-set-idle-time:
timer.el:71:44:Warning: reference to free variable `time'

reply via email to

[Prev in Thread] Current Thread [Next in Thread]