Re: Visiting files with gnuclient don't add to history

[Slawomir Nowaczyk]

On Sun, 17 Sep 2006 02:08:37 +0200
Lennart Borgman <address@hidden> wrote:

#> Jason Rumney wrote:
#> > Slawomir Nowaczyk <address@hidden> writes:

#> >> Is this a problem in Emacs or is there something wrong with my
#> >> version of gnuserv/gnuclient?
#> >
#> > The code that visits the files sent by gnuclient will be in
#> > gnuserv.el, so that would be the first place to look.
#> 
#> Slawomir, which gnuserv/gnuclient are you using?

I am not entirely sure... I remember it took me quite some time (long
ago) before I found a version which actually worked reliably. My
gnuserv.el contains this:

(defconst gnuserv-rcs-header-id "$Header: gnuserv.el,v 2.1 95/02/16 12:00:16 
arup alpha $")

but that is probably meaningless, since the latest change (of those
listed explicitly, at least) is:

;; Lennart Borgman <lennart DOT borgman DOT 073 AT student DOT lu DOT se> 
2005-01-29
;;      Added aliases for old server-* functions called from gnuclient.

I have now downloaded a seemingly newer version (at least, the gnuclient
program has new Emacs icon and is 900kb in size, as opposed to 80kb
which I have been using ;) from http://www.emacswiki.org/cgi-bin/wiki/GnuClient
namely this: 
http://ourcomments.org/Emacs/DL/EmacsW32%20only/EmacsW32-alone-1.06.zip

(I did not want to download the whole EmacsW32)

#> Are you on w32?

Yes. But I use "pure" emacs, pulled from CVS and compiled by myself, not
EmacsW32.

#> I just added a line to gnuserv.el that should fix the problem:

Thanks, I applied this patch and it works great.

The reason I have wrote here, though, is that the version of gnuserv I
was using, without this modification, *used to* work just fine a couple
of weeks/months ago. I do not know what changed... all I found in NEWS
(searching for "history") which could be related are those two changes:

*** New function `add-to-history' adds an element to a history list.
*** The new variable `history-add-new-input' specifies whether to add new

but I do not see from their descriptions why should they affect things
like gnuserv. I may miss something, but if this was supposed to be an
incompatible change, maybe it would be worthwhile to document it better.
And if not, then maybe there is a bug somewhere.

-- 
 Best wishes,
   Slawomir Nowaczyk
     ( address@hidden )

Real Programmers just whistle the binary code into the modem