[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: shell-command - missing shell-quote-argument for program?

From: Lennart Borgman
Subject: Re: shell-command - missing shell-quote-argument for program?
Date: Tue, 10 Oct 2006 09:02:24 +0200
User-agent: Thunderbird (Windows/20060909)

Slawomir Nowaczyk wrote:
On Tue, 10 Oct 2006 00:14:46 +0200
Lennart Borgman <address@hidden> wrote:

#> I found examples of what I suspected was missing quoting in the files
#> I mentioned and I therefore mailed you as authors (since there is no
#> maintainer mentioned in the files).


#> Here are the files again:
#> #> - progmodes/python.el: python-after-info-look: python-command

I am not entirely sure it is needed, but the following shouldn't hurt in
any case.


--- m:/EmacsCVS/EmacsCVS/lisp/progmodes/python.el       2006-09-26 
20:28:22.912208000 +0200
+++ c:/Emacs/lisp/progmodes/python.el   2006-10-10 08:39:42.179456000 +0200
@@ -1630,7 +1630,7 @@
 (defun python-after-info-look ()
   "Set up info-look for Python.
 Used with `eval-after-load'."
-  (let* ((version (let ((s (shell-command-to-string (concat python-command
+  (let* ((version (let ((s (shell-command-to-string (concat 
(shell-quote-argument python-command)
                                                            " -V"))))
                    (string-match "^Python \\([0-9]+\\.[0-9]+\\>\\)" s)
                    (match-string 1 s)))


Thanks, but it looks to me that this should not be quoted. `python-command' is not just a file.

My mistake. Sorry.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]