[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Quote file name args to start-process-shell-command?
From: |
Stefan Monnier |
Subject: |
Re: Quote file name args to start-process-shell-command? |
Date: |
Mon, 16 Oct 2006 02:44:35 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
>> >> The notion of what is simpler is clearly objective and we may never agree,
>> > That is exactly why I asked for _your_ notion of ``simpler''.
>>
>> >> but I may be satisfied by a concrete example which you consider
>> >> as simpler.
>> >[silence]
>>
>> The absence of answer here seems to indicate that you don't have a concrete
>> example which *you* consider as simpler.
> And what does _your_ silence mean to my request of telling what is
> your notion of simpler?
It means that I don't know how to define it.
> I don't want to waste my time to come up with examples only to hear
> you say ``that's not simpler''.
As I said: I may be satisfied by a concrete example which you consider
as simpler.
Basically, I see no evidence that we'll strongly disagree on what is simpler.
To get the thing rolling, he is my rewrite of pgg-pgp.el to avoid the use of
a list of args. It fixes a few missing shell-quote-arguments and replaces
a few (concat "\"" foo "\"") with calls to shell-quote-arguments.
The only other place I could find where the `args' feature of
start-process-shell-command is used is in pgg-pgp5.el which is basically
a copy of pgg-pgp.el so the patch can trivially be adapted, although I'd
rather not do that since I think pgg-pgp5.el has no business being in Emacs,
owing to the fact that pgp5 is not Free Software.
Do you find my new code less simple?
Stefan
PS: It also fixes a bug in the handling of pgg-pgp-extra-args: the
defcustom says it should be a string, but the previous code assumed it was
a list of strings instead.
--- pgg-pgp.el 03 jui 2006 14:46:24 -0400 1.4
+++ pgg-pgp.el 16 oct 2006 01:36:27 -0400
@@ -63,9 +63,9 @@
(defun pgg-pgp-process-region (start end passphrase program args)
(let* ((errors-file-name (pgg-make-temp-file "pgg-errors"))
(args
- (append args
+ (concat args
pgg-pgp-extra-args
- (list (concat "2>" errors-file-name))))
+ " 2>" (shell-quote-argument errors-file-name)))
(shell-file-name pgg-pgp-shell-file-name)
(shell-command-switch pgg-pgp-shell-command-switch)
(process-environment process-environment)
@@ -83,9 +83,8 @@
(let ((coding-system-for-read 'binary)
(coding-system-for-write 'binary))
(setq process
- (apply #'funcall
- #'start-process-shell-command "*PGP*" output-buffer
- program args)))
+ (start-process-shell-command "*PGP*" output-buffer
+ (concat program " " args))))
(set-process-sentinel process #'ignore)
(when passphrase
(process-send-string process (concat passphrase "\n")))
@@ -142,15 +141,14 @@
pgg-pgp-user-id)
pgg-pgp-user-id))))
(args
- (append
- `("+encrypttoself=off +verbose=1" "+batchmode"
- "+language=us" "-fate"
- ,@(if recipients
- (mapcar (lambda (rcpt) (concat "\"" rcpt "\""))
+ (concat
+ "+encrypttoself=off +verbose=1 +batchmode +language=us -fate"
+ (if recipients
+ (mapconcat 'shell-quote-argument
(append recipients
(if pgg-encrypt-for-me
- (list pgg-pgp-user-id))))))
- (if sign '("-s" "-u" pgg-pgp-user-id)))))
+ (list pgg-pgp-user-id)))))
+ (if sign (concat " -s -u " (shell-quote-argument
pgg-pgp-user-id))))))
(pgg-pgp-process-region start end nil pgg-pgp-program args)
(pgg-process-when-success nil)))
@@ -166,7 +164,7 @@
(pgg-read-passphrase
(format "PGP passphrase for %s: " pgg-pgp-user-id) key)))
(args
- '("+verbose=1" "+batchmode" "+language=us" "-f")))
+ "+verbose=1 +batchmode +language=us -f"))
(pgg-pgp-process-region start end passphrase pgg-pgp-program args)
(pgg-process-when-success
(if pgg-cache-passphrase
@@ -184,9 +182,9 @@
(format "PGP passphrase for %s: " pgg-pgp-user-id)
(pgg-pgp-lookup-key pgg-pgp-user-id 'sign))))
(args
- (list (if clearsign "-fast" "-fbast")
- "+verbose=1" "+language=us" "+batchmode"
- "-u" pgg-pgp-user-id)))
+ (concat (if clearsign "-fast" "-fbast")
+ " +verbose=1 +language=us +batchmode"
+ " -u " (shell-quote-argument pgg-pgp-user-id))))
(pgg-pgp-process-region start end passphrase pgg-pgp-program args)
(pgg-process-when-success
(goto-char (point-min))
@@ -204,7 +202,7 @@
(defun pgg-pgp-verify-region (start end &optional signature)
"Verify region between START and END as the detached signature SIGNATURE."
(let* ((orig-file (pgg-make-temp-file "pgg"))
- (args '("+verbose=1" "+batchmode" "+language=us"))
+ (args "+verbose=1 +batchmode +language=us"))
(orig-mode (default-file-modes)))
(unwind-protect
(progn
@@ -216,8 +214,8 @@
(if (stringp signature)
(progn
(copy-file signature (setq signature (concat orig-file ".asc")))
- (setq args (append args (list signature orig-file))))
- (setq args (append args (list orig-file))))
+ (setq args (concat args " " (shell-quote-argument signature)))))
+ (setq args (concat args " " (shell-quote-argument orig-file)))
(pgg-pgp-process-region (point)(point) nil pgg-pgp-program args)
(delete-file orig-file)
(if signature (delete-file signature))
@@ -237,8 +235,8 @@
"Insert public key at point."
(let* ((pgg-pgp-user-id (or pgg-pgp-user-id pgg-default-user-id))
(args
- (list "+verbose=1" "+batchmode" "+language=us" "-kxaf"
- (concat "\"" pgg-pgp-user-id "\""))))
+ (concat "+verbose=1 +batchmode +language=us -kxaf "
+ (shell-quote-argument pgg-pgp-user-id))))
(pgg-pgp-process-region (point)(point) nil pgg-pgp-program args)
(insert-buffer-substring pgg-output-buffer)))
@@ -247,8 +245,8 @@
(let* ((pgg-pgp-user-id (or pgg-pgp-user-id pgg-default-user-id))
(key-file (pgg-make-temp-file "pgg"))
(args
- (list "+verbose=1" "+batchmode" "+language=us" "-kaf"
- key-file)))
+ (concat "+verbose=1 +batchmode +language=us -kaf "
+ (shell-quote-argument key-file))))
(let ((coding-system-for-write 'raw-text-dos))
(write-region start end key-file))
(pgg-pgp-process-region start end nil pgg-pgp-program args)
@@ -257,5 +255,5 @@
(provide 'pgg-pgp)
-;;; arch-tag: 076b7801-37b2-49a6-97c3-218fdecde33c
+;; arch-tag: 076b7801-37b2-49a6-97c3-218fdecde33c
;;; pgg-pgp.el ends here
- Re: Quote file name args to start-process-shell-command?, (continued)
- Re: Quote file name args to start-process-shell-command?, Stefan Monnier, 2006/10/12
- Re: Quote file name args to start-process-shell-command?, Eli Zaretskii, 2006/10/13
- Re: Quote file name args to start-process-shell-command?, Stefan Monnier, 2006/10/13
- Re: Quote file name args to start-process-shell-command?, Eli Zaretskii, 2006/10/13
- Re: Quote file name args to start-process-shell-command?, Stefan Monnier, 2006/10/13
- Re: Quote file name args to start-process-shell-command?, Eli Zaretskii, 2006/10/14
- Re: Quote file name args to start-process-shell-command?, Stefan Monnier, 2006/10/14
- Re: Quote file name args to start-process-shell-command?, Eli Zaretskii, 2006/10/14
- Re: Quote file name args to start-process-shell-command?, Stefan Monnier, 2006/10/15
- Re: Quote file name args to start-process-shell-command?, Eli Zaretskii, 2006/10/16
- Re: Quote file name args to start-process-shell-command?,
Stefan Monnier <=
- Re: Quote file name args to start-process-shell-command?, Andreas Schwab, 2006/10/16
- Re: Quote file name args to start-process-shell-command?, Richard Stallman, 2006/10/16
- Re: Quote file name args to start-process-shell-command?, Richard Stallman, 2006/10/15
- Re: Quote file name args to start-process-shell-command?, Eli Zaretskii, 2006/10/12
- Re: Quote file name args to start-process-shell-command?, David Kastrup, 2006/10/12
- Re: Quote file name args to start-process-shell-command?, Eli Zaretskii, 2006/10/12
- Re: Quote file name args to start-process-shell-command?, Richard Stallman, 2006/10/12
- Re: Quote file name args to start-process-shell-command?, Stefan Monnier, 2006/10/12
- Re: Quote file name args to start-process-shell-command?, Lennart Borgman, 2006/10/13
- Re: Quote file name args to start-process-shell-command?, Kim F. Storm, 2006/10/13