Re: M-x ediff-files doesn't notify user of missing ediff-diff-program

[Chong Yidong]

Nick Roberts <address@hidden> writes:

> Andrew M. Scott writes:
>  > Neither
>  > 
>  >  M-x ediff-buffers buf1 buf2
>  > nor
>  >  M-x ediff-files file1 file2
>  > 
>  > complain if there isn't an ediff-diff-command on exec-path. Instead, 
>  > a user can type consecutive "n"'s in the *Ediff Control Panel* without
>  > seeing any highlighted diffs (which erroneously leads the user to
>  > think there are no diffs).
>
> It worked in Emacs 21.3.  This seems to be a regression in ediff-exec-process
> (ediff-diff.el) :

The following patch should fix it.  Any objections?

*** emacs/lisp/ediff-diff.el.~1.55.~    2006-10-25 10:42:24.000000000 -0400
--- emacs/lisp/ediff-diff.el    2006-10-25 10:46:24.000000000 -0400
***************
*** 1276,1282 ****
                ;; asynchronous processes.
                (condition-case nil
                    (apply 'call-process program nil buffer nil args)
!                 (error (format "Cannot execute program %S." program)))
              ;; On other systems, do it asynchronously.
              (setq proc (get-buffer-process buffer))
              (if proc (kill-process proc))
--- 1276,1282 ----
                ;; asynchronous processes.
                (condition-case nil
                    (apply 'call-process program nil buffer nil args)
!                 (error (error "Cannot execute program %S." program)))
              ;; On other systems, do it asynchronously.
              (setq proc (get-buffer-process buffer))
              (if proc (kill-process proc))