emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: install error on Mac OS X


From: Jan Djärv
Subject: Re: install error on Mac OS X
Date: Tue, 07 Nov 2006 08:26:45 +0100
User-agent: Thunderbird 1.5.0.7 (X11/20060913)



YAMAMOTO Mitsuharu skrev:
On Mon, 06 Nov 2006 16:00:25 -0500, Richard Stallman <address@hidden> said:

To use X should require a specific option.
    What should we do for the case that --with-x-toolkit (or other
    X-specific options) is specified without explicit --with-x or
    --without-carbon?

It would make sense for --with-x-toolkit to imply --with-x.

Could anyone who is familiar with autoconf check the following patch?

                                     YAMAMOTO Mitsuharu
                                address@hidden

Index: configure.in
===================================================================
RCS file: /cvsroot/emacs/emacs/configure.in,v
retrieving revision 1.416
diff -c -r1.416 configure.in
*** configure.in        4 Nov 2006 03:28:27 -0000       1.416
--- configure.in        7 Nov 2006 01:58:43 -0000
***************
*** 1779,1785 ****
  if test "${window_system}" = x11 && test "${HAVE_CARBON}" = yes; then
    if test "${with_carbon+set}" != set \
       && test "${carbon_appdir_x+set}" != set; then
!     HAVE_CARBON=no
    fi
  fi
  if test "${HAVE_CARBON}" = yes; then
--- 1779,1791 ----
  if test "${window_system}" = x11 && test "${HAVE_CARBON}" = yes; then
    if test "${with_carbon+set}" != set \
       && test "${carbon_appdir_x+set}" != set; then
!     for var in with_x with_x_toolkit with_gtk with_xim \
!                with_xpm with_jpeg with_tiff with_gif with_png; do
!       if test "`eval 'echo \"${'\"$var\"'+set}\"'`" = set; then
!         HAVE_CARBON=no
!         break
!       fi
!     done
    fi
  fi
  if test "${HAVE_CARBON}" = yes; then

For clarity, and to get rid of the backticks, I would write the for loop like this:

  for var in with_x with_x_toolkit with_gtk with_xim \
             with_xpm with_jpeg with_tiff with_gif with_png; do
     eval "x=\${$var+set}";
     if test "$x" = set; then
     ...

Other than that, it looks fine.

        Jan D.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]