[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: string-to-char

From: Nick Roberts
Subject: Re: string-to-char
Date: Tue, 28 Nov 2006 08:32:34 +1300

 > And some of those uses are quite weird, BTW:
 >  - In erc/erc.el:
 >     (separator (make-string erc-fill-column (string-to-char "=")))
 >     (make-string (length x) (string-to-char "b"))
 >  - In progmodes/fortran.el:
 >     (or (equal char (string-to-char " "))
 > Aren't these redundant? (I don't think the unibyte/multibyte issue is
 > relevant in any of them...)

Very probably.  The problem with changing them and the large numbers of files
to which you are applying trivial fixes is that the code being pretested is no
longer that in the repository.  I think it's best to follow the adage: "If it
ain't broke then don't fix it.".  At least, until After The Release (TM).

Nick                                           http://www.inet.net.nz/~nickrob

reply via email to

[Prev in Thread] Current Thread [Next in Thread]