emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FACE_TTY_DEFAULT_* redefined in dispextern.h


From: Eli Zaretskii
Subject: Re: FACE_TTY_DEFAULT_* redefined in dispextern.h
Date: Sat, 02 Dec 2006 14:22:28 +0200

> This is due to these lines in dispnew.c:
>       FRAME_FOREGROUND_PIXEL (sf) = FACE_TTY_DEFAULT_FG_COLOR;
>       FRAME_BACKGROUND_PIXEL (sf) = FACE_TTY_DEFAULT_BG_COLOR;
> 
> which expand to:
>       ((sf)->output_data.x->foreground_pixel) = ((unsigned long) -2);
>       ((sf)->output_data.x->background_pixel) = ((unsigned long) -3);
> 
> foreground_pixel and background_pixel are int (size 4) on my system, 
> while unsigned long is size 8.

I think the change you are suggesting is not the right one, since
xterm.h has this in its definition of x_output:

    struct x_output
    {
      ...
      unsigned long background_pixel;
      unsigned long foreground_pixel;

I think we should instead redefine PIX_TYPE in this fragment of
frame.h to be unsigned long instead of int:

    #if !defined(MSDOS) && !defined(WINDOWSNT) && !defined(MAC_OS)

    #if !defined(HAVE_X_WINDOWS)

    #define PIX_TYPE int

Could you please see if such a change fixes your problems?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]