[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: address@hidden: Calendar hack: Displaying ISO weeks, update for emac
Re: address@hidden: Calendar hack: Displaying ISO weeks, update for emacs 22]
Sat, 02 Dec 2006 16:40:54 -0500
Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux)
Richard Stallman <address@hidden> writes:
> We deleted the variable `facemenu-unlisted-faces' because it didn't do
> anything. But this method shows that we must have lost the
> functionality since 21, and that we need to add it back.
> Would someone please reimplement it, then ack?
We deleted it because of a bug report that too many unwanted faces
were added to the facemenu. It's far cleaner to provide a list of
faces to include --- the new variable `facemenu-listed-faces' --- than
a list of faces to exclude.
How about this patch, which defines an obsolete variable
`facemenu-unlisted faces'? It should provide the necessary amount of
backward compatibility to accomodate user code that looks for such a
variable, as in the current bug report.
*** emacs/lisp/facemenu.el.~1.92.~ 2006-11-29 23:19:17.000000000 -0500
--- emacs/lisp/facemenu.el 2006-12-02 16:37:33.000000000 -0500
*** 132,137 ****
--- 132,147 ----
+ (defvar facemenu-unlisted-faces
+ `(modeline region secondary-selection highlight scratch-face
+ ,(purecopy "^font-lock-") ,(purecopy "^gnus-") ,(purecopy "^message-")
+ ,(purecopy "^ediff-") ,(purecopy "^term-") ,(purecopy "^vc-")
+ ,(purecopy "^widget-") ,(purecopy "^custom-") ,(purecopy "^vm-"))
+ "*List of faces that are of no interest to the user.
+ This variable is obsolete, and has no effect on the Face menu.
+ Use the variable `facemenu-listed-faces' instead.")
+ (make-obsolete-variable 'facemenu-unlisted-faces 'facemenu-listed-faces)
(defcustom facemenu-listed-faces nil
"*List of faces to include in the Face menu.
Each element should be a symbol, the name of a face.