[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FACE_TTY_DEFAULT_* redefined in dispextern.h

From: Francesco Potorti`
Subject: Re: FACE_TTY_DEFAULT_* redefined in dispextern.h
Date: Mon, 04 Dec 2006 11:52:35 +0100

>> This is due to these lines in dispnew.c:
>> which expand to:
>>       ((sf)->output_data.x->foreground_pixel) = ((unsigned long) -2);
>>       ((sf)->output_data.x->background_pixel) = ((unsigned long) -3);
>> foreground_pixel and background_pixel are int (size 4) on my system, 
>> while unsigned long is size 8.
>I think the change you are suggesting is not the right one, since
>xterm.h has this in its definition of x_output:
>    struct x_output
>    {
>      ...
>      unsigned long background_pixel;
>      unsigned long foreground_pixel;
>I think we should instead redefine PIX_TYPE in this fragment of
>frame.h to be unsigned long instead of int:
>    #if !defined(MSDOS) && !defined(WINDOWSNT) && !defined(MAC_OS)
>    #if !defined(HAVE_X_WINDOWS)
>    #define PIX_TYPE int
>Could you please see if such a change fixes your problems?

I defined PIX_TYPE to be unsigned long rather than int: now no warnings
are elicited while compiling dispnew.c and the compilation process
completes without errors.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]