emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: SVG support in Emacs: what happened?


From: Eli Zaretskii
Subject: Re: SVG support in Emacs: what happened?
Date: Sat, 20 Jan 2007 15:36:10 +0200

> From: Paul Pogonyshev <address@hidden>
> Date: Sat, 20 Jan 2007 02:10:34 +0200
> Cc: Benjamin Hawkes-Lewis <address@hidden>, address@hidden
> > 
> > 1. What does the code need to make it "portable"?
> 
> Probably input of someone on Windows.  I'm sure it won't compile there
> simply because I made no effort for this.

The patch indeed needs some work to avoid breaking the Windows port.
As posted, the patch will try to compile the SVG code unconditionally,
since it uses very strange conditionals to enable SVG:

    #if 1 || defined (HAVE_RSVG)

If these are replaced with the usual "#if HAVE_RSVG", then I think
MS-Windows will not be a problem.

One other issue would be to see whether the configure test is okay.
For example, do we really want to use pkg-config for that? do all
platforms that have SVG also have pkg-config?

> > 3. Is Paul (or anyone else) (in 2007) "willing to have a try" at turning
> > it from a "first shot" into a final patch?
> 
> Not as I know.  I'm not going to work on it until Emacs trunk is
> "unfrozen".  It might as well take another year or two, so it is
> meaningless for me (as not a core Emacs developer) to spend time on it.

FWIW, I don't think we should add this code during the pretest.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]