[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: SVG support in Emacs: what happened?

From: Paul Pogonyshev
Subject: Re: SVG support in Emacs: what happened?
Date: Sat, 20 Jan 2007 21:48:48 +0200
User-agent: KMail/1.7.2

Eli Zaretskii wrote:
> > From: Paul Pogonyshev <address@hidden>
> > Date: Sat, 20 Jan 2007 02:10:34 +0200
> > Cc: Benjamin Hawkes-Lewis <address@hidden>, address@hidden
> > > 
> > > 1. What does the code need to make it "portable"?
> > 
> > Probably input of someone on Windows.  I'm sure it won't compile there
> > simply because I made no effort for this.
> The patch indeed needs some work to avoid breaking the Windows port.
> As posted, the patch will try to compile the SVG code unconditionally,
> since it uses very strange conditionals to enable SVG:
>     #if 1 || defined (HAVE_RSVG)

I added this because I didn't run `autoconf' or `autoheader, it was
mentioned in my message.  Of course it should be replaced with a proper

Also, drawing code is not portable and was adapted from some existing
code for X.  Don't remember which exactly.

> One other issue would be to see whether the configure test is okay.
> For example, do we really want to use pkg-config for that? do all
> platforms that have SVG also have pkg-config?

AFAIK, librsvg tests for pkg-config in its own `configure' script.

> > > 3. Is Paul (or anyone else) (in 2007) "willing to have a try" at turning
> > > it from a "first shot" into a final patch?
> > 
> > Not as I know.  I'm not going to work on it until Emacs trunk is
> > "unfrozen".  It might as well take another year or two, so it is
> > meaningless for me (as not a core Emacs developer) to spend time on it.
> FWIW, I don't think we should add this code during the pretest.

Sure we shouldn't.  I just wish pretest doesn't take forever.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]