[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is this tempo.el patch correct?

From: David Kågedal
Subject: Re: Is this tempo.el patch correct?
Date: Fri, 9 Mar 2007 23:46:38 +0100

9 mar 2007 kl. 22.26 skrev Richard Stallman:

David K}gedal, author of tempo.el, seems not to be responding,
so we are on our own unless someone can find a better way to contact him.

Would someone please DTRT and then ack?

I'm sorry. I'm here, and I put your mail on the pile of things to take care of RSN.

Since I haven't really done anything with tempo.el for ten years, it takes a bit of mental effort to review patches. But I'll have a look tomorrow.

------- Start of forwarded message -------
To: address@hidden
From: Lawrence Mitchell <address@hidden>
Date: Fri, 02 Mar 2007 14:39:11 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: r> insertion marker not handled correctly in tempo
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed

If you define a tempo template that includes the "r>" insertion
marker, attempting to use that template results in an error that the
function "r>" is undefined.

This bug may be reproduced as follows:

emacs -Q


  (require 'tempo)
   '("Some string" n> (r> "body: ")))
  (setq debug-on-error t)

The following patch fixes this problem in, I believe, the correct

Index: tempo.el
RCS file: /sources/emacs/emacs/lisp/tempo.el,v
retrieving revision
diff -c -r1.20.6.11 tempo.el
*** tempo.el    26 Jan 2007 06:15:15 -0000
- --- tempo.el  2 Mar 2007 14:36:39 -0000
*** 352,357 ****
- --- 352,364 ----
                                         (goto-char tempo-region-stop)
                                        (cdr element))))
+         ((and (consp element)
+               (eq (car element) 'r>)) (if on-region
+                                           (progn
+ (goto-char tempo- region-stop) + (indent-region (mark) (point) nil))
+                                         (tempo-insert-prompt-compat
+                                          (cdr element))))
        ((and (consp element)
(eq (car element) 's)) (tempo-insert-named (car (cdr element))))
        ((and (consp element)

Changelog entry:

2007-03-02  Lawrence Mitchell  <address@hidden>

        * tempo.el (tempo-insert): Deal with 'r> if it appears
        specified with a prompt argument.



- --
Lawrence Mitchell <address@hidden>

emacs-pretest-bug mailing list
------- End of forwarded message -------

David Kågedal

reply via email to

[Prev in Thread] Current Thread [Next in Thread]