[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

diff-apply-hunk documentation doesn't match implementation

From: Andreas Schwab
Subject: diff-apply-hunk documentation doesn't match implementation
Date: Sun, 11 Mar 2007 13:00:25 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux)

The doc string of diff-apply-hunk says:

  By default, the new source file is patched, but if the variable
  `diff-jump-to-old-file' is non-nil, then the old source file is
  patched instead

But the implementation then goes on to do the opposite:

      ;; If REVERSE go to the new file, otherwise go to the old.
      (diff-find-source-location (not reverse) reverse)

IMHO the implementation should be changed to match documentation, since
the current behaviour is quite counter-intuitive.


Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]