[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes to let woman.el deal with MANPATH_MAP elements

From: David Kastrup
Subject: Re: Fixes to let woman.el deal with MANPATH_MAP elements
Date: Fri, 23 Mar 2007 21:03:16 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux)

David Kastrup <address@hidden> writes:

> Eli Zaretskii <address@hidden> writes:
>>> From: David Kastrup <address@hidden>
>>> Date: Fri, 23 Mar 2007 11:29:25 +0100
>>> Both problems appear fixed with the following rather straightforward
>>> patch.  While it clearly fixes faulty behavior, it could be considered
>>> bordering on "new feature".
>>> Should I still apply it?
>> That's something for Richard to decide.
>>> !         (unless path (setq path (split-string (getenv "PATH") ":" t)))
>> Please don't install such unportable code: only Posix platforms use
>> `:' to separate directories in PATH and other similar variables.
>> Please use `path-separator' instead.
> Thanks, that was important information.  It would not have broken
> previously existing behavior, but would not have helped, either.  I'll
> rework the patch.


I am utterly befuddled by the code in woman.el.  Should I be using
"parse-colon-path" or "woman-parse-colon-path" here?

It is not clear to me whether "PATH" is covered by the same special
rules that either one of the above functions would use.

As the code appears to be cowritten by you, could you suggest what to
use instead of

(split-string (getenv "PATH") ":" t)

here?  Should I use one of the above-mentioned functions, or just
(split-string (getenv "PATH") path-separator t)?


David Kastrup, Kriemhildstr. 15, 44793 Bochum

reply via email to

[Prev in Thread] Current Thread [Next in Thread]